Re: [PATCH net-next v8 09/10] net: gianfar: Use device_get_child_node_count_named()
From: Simon Horman
Date: Wed Mar 19 2025 - 12:09:12 EST
On Mon, Mar 17, 2025 at 05:52:25PM +0200, Matti Vaittinen wrote:
> We can avoid open-coding the loop construct which counts firmware child
> nodes with a specific name by using the newly added
> device_get_child_node_count_named().
>
> The gianfar driver has such open-coded loop. Replace it with the
> device_get_child_node_count_named().
>
> Suggested-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> Signed-off-by: Matti Vaittinen <mazziesaccount@xxxxxxxxx>
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
This patch looks good to me.
But I think it would be best to resubmit it,
as a standalone patch for net-next, once
it's dependencies are present in net-next.
--
pw-bot: defer