[PATCH v2 11/13] iio: light: al3320a: Improve error handling with dev_err_probe

From: David Heidelberg via B4 Relay
Date: Wed Mar 19 2025 - 17:01:15 EST


From: David Heidelberg <david@xxxxxxx>

Slight simplification of the code.

Signed-off-by: David Heidelberg <david@xxxxxxx>
---
drivers/iio/light/al3320a.c | 10 ++++------
1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/drivers/iio/light/al3320a.c b/drivers/iio/light/al3320a.c
index 1b2b0359ed5dad5e00d2fe584f8f3495c13c997e..1943e6f34a70b00b5d732dbf4ae6ccb4376303b7 100644
--- a/drivers/iio/light/al3320a.c
+++ b/drivers/iio/light/al3320a.c
@@ -206,14 +206,12 @@ static int al3320a_probe(struct i2c_client *client)
indio_dev->modes = INDIO_DIRECT_MODE;

ret = al3320a_init(data);
- if (ret < 0) {
- dev_err(dev, "al3320a chip init failed\n");
- return ret;
- }
+ if (ret)
+ return dev_err_probe(dev, ret, "failed to init ALS\n");

ret = devm_add_action_or_reset(dev, al3320a_set_pwr_off, data);
- if (ret < 0)
- return ret;
+ if (ret)
+ return dev_err_probe(dev, ret, "failed to add action\n");

return devm_iio_device_register(dev, indio_dev);
}

--
2.49.0