Re: [PATCH v6 4/9] gpio: aggregator: introduce basic configfs interface

From: Bartosz Golaszewski
Date: Fri Mar 21 2025 - 08:45:32 EST


On Fri, Mar 21, 2025 at 1:33 PM Koichiro Den <koichiro.den@xxxxxxxxxxxxx> wrote:
>
>
> Actually I wasn't aware of [1]. So let me summarize: does this match what
> you have in mind?
>
> Before this patch series:
> * forwarder: gpiochip_fwd_* + gpio_fwd_*
> * sysfs interface: new_device/delete_device + aggr_*
> * platform device: gpio_aggregator_*
> * module init/exit: gpio_aggregator_*
>
> After this patch series:
> * common utils: gpio_aggregator_*
> * forwarder: gpio_forwarder_*

Best don't change it in this series unless you touch the code. If you
do, then yes, gpio_forwarder_ works.

> * configfs: gpio_aggregator_*
> * sysfs interface: new_device/delete_device <-- _Unchanged_

Do change this one to also use the gpio_aggregator_ prefix.

> * platform device: gpio_aggregator_* <-- _Unchanged_
> * module init/exit: gpio_aggregator_* <-- _Unchanged_
>
> Thanks,
>
> Koichiro
>
> >
> > Bartosz
> >
> > [1] https://lore.kernel.org/all/20250317-aaeon-up-board-pinctrl-support-v2-0-36126e30aa62@xxxxxxxxxxx/

Bartosz