Re: [PATCH v6 4/9] gpio: aggregator: introduce basic configfs interface

[Koichiro Den]

On Fri, Mar 21, 2025 at 01:42:49PM GMT, Bartosz Golaszewski wrote:
> On Fri, Mar 21, 2025 at 1:33 PM Koichiro Den <koichiro.den@xxxxxxxxxxxxx> wrote:
> >
> >
> > Actually I wasn't aware of [1]. So let me summarize: does this match what
> > you have in mind?
> >
> >   Before this patch series:
> >   * forwarder:        gpiochip_fwd_* + gpio_fwd_*
> >   * sysfs interface:  new_device/delete_device + aggr_*
> >   * platform device:  gpio_aggregator_*
> >   * module init/exit: gpio_aggregator_*
> >
> >   After this patch series:
> >   * common utils:     gpio_aggregator_*
> >   * forwarder:        gpio_forwarder_*
> 
> Best don't change it in this series unless you touch the code. If you
> do, then yes, gpio_forwarder_ works.

This patch series does not touch GPIO forwarder code, while touching all
the other things to some extent. Ok, I won't change prefixes for forwarder
codes.

> 
> >   * configfs:         gpio_aggregator_*
> >   * sysfs interface:  new_device/delete_device     <-- _Unchanged_
> 
> Do change this one to also use the gpio_aggregator_ prefix.

Alright, so what you want is: everything except GPIO forwarder code should
be prefixed with gpio_aggregator_ (perhaps except for some small exceptions
e.g.  to_gpio_aggregator()), right?

Thanks,

Koichiro

> 
> >   * platform device:  gpio_aggregator_*            <-- _Unchanged_
> >   * module init/exit: gpio_aggregator_*            <-- _Unchanged_
> >
> > Thanks,
> >
> > Koichiro
> >
> > >
> > > Bartosz
> > >
> > > [1] https://lore.kernel.org/all/20250317-aaeon-up-board-pinctrl-support-v2-0-36126e30aa62@xxxxxxxxxxx/
> 
> Bartosz