Re: [v6] dma-engine: sun4i: Simplify error handling in probe()

From: Csókás Bence
Date: Tue Mar 25 2025 - 09:21:36 EST


Hi Julian,

On 2025. 03. 25. 13:20, Julian Calaby wrote:
Hi Markus,

I really wanted to keep out of this, but...

On Tue, Mar 25, 2025 at 8:14 PM Markus Elfring <Markus.Elfring@xxxxxx> wrote:

Implementation details are probably worth for another look.

What don't you like in the implementation? Let's discuss that then.

I dare to point concerns out also for the development process.

You're "concerned" about patch granularity, but this is not the sort
of thing that some random person would raise, this is the sort of
thing a maintainer asks for when patches are doing too many things or
are unreviewable. This is neither. It is a very simple cleanup of a
probe function as it says in the patch subject.

Exactly. That's why I asked if it broke something on Markus' end, because it is a really specific thing to nitpick about, especially in a changeset this small. So far, he did not indicate the *reasons* why he thinks this should be split further.

Futhermore, this already has an ack from the maintainer of this file.
This indicates that they're happy with it and no significant changes
are required. This is also version 6 of the patch, if the maintainer
was concerned about this, they'd have already provided some clear
guidance on this. If you check previous versions of this patch, no
such requests have been made.

Your only other "concern" had already been addressed as has already
been pointed out to you.

Please distinguish better between information from the “changelog”
and items in a message subject.

What do you mean? The email body will be the commit message.
See also:
https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.14#n623

The email and patch structure are following the format outlined in the
document you link to _exactly_.


Once again your comments are just noise, and your insistence on
repeating them over and over and over and over and over again is
borderline harassment.

You have been told to stop this nonsense many many times, here's a
link to the most recent one:

https://lore.kernel.org/all/92d1a410788c54facedec033474046dda6a1a2cc.camel@xxxxxxxxxxxxxxxx/

Please stop sending these emails and go do something constructive with
your life.

* * * * *

Bence Csókás, (I hope I've got the order of your names correct)

Either order works, Bence is the given name, and Csókás is the family name (surname). Hungarian and Japanese order follows the scientific "Surname, Given Name(s)" order, but commas broke many tools, including Git < v2.46, and b4, so I switched to the germanic "Firstname Lastname" format.

Please block or ignore Markus, at best he's a nuisance and at worst a troll.

I'm still open to hear him out if, and only if, he can give *clear and valid* reasoning on why he wants to achieve this. I'm a generally understanding person. But if it's just hand-waving and linking to the same page over and over again with no explanation on why he _thinks_ I broke SubmittingPatches, then I will do exactly this.

Lastly, to all other adressees, sorry for the spam. So let's end this meta-discussion here and keep the rest of the conversation professional, reasoning about the technicals.

Bence