Re: [v6] dma-engine: sun4i: Simplify error handling in probe()

[Julian Calaby]

Hi Bence,

On Tue, Mar 25, 2025 at 11:39 PM Csókás Bence <csokas.bence@xxxxxxxxx> wrote:
>
> Hi Julian,
>
> On 2025. 03. 25. 13:20, Julian Calaby wrote:

[snip]

> > Bence Csókás, (I hope I've got the order of your names correct)
>
> Either order works, Bence is the given name, and Csókás is the family
> name (surname). Hungarian and Japanese order follows the scientific
> "Surname, Given Name(s)" order, but commas broke many tools, including
> Git < v2.46, and b4, so I switched to the germanic "Firstname Lastname"
> format.

Thanks for that, I'll try to keep that in mind!

[snip]

> Lastly, to all other adressees, sorry for the spam. So let's end this
> meta-discussion here and keep the rest of the conversation professional,
> reasoning about the technicals.

And this is why I was so hessitant to step in here.

Getting back to that, your patch looks good to me and it's awesome how
the devm_ functions and their frends can simplify things.

I'm going to point out that this does swap the clock enable and reset
deassert, but I'm assuming that is harmless.

Reviewed-by: Julian Calaby <julian.calaby@xxxxxxxxx>

Thanks,

-- 
Julian Calaby

Email: julian.calaby@xxxxxxxxx
Profile: http://www.google.com/profiles/julian.calaby/