Re: [PATCH] drm/edid: Add non-desktop quirk for Playstation VR Headsets with Product ID 0xB403

[Jani Nikula]

On Tue, 25 Mar 2025, Maxime Ripard <mripard@xxxxxxxxxx> wrote:
> On Tue, Mar 25, 2025 at 12:47:49PM +0200, Jani Nikula wrote:
>> On Tue, 25 Mar 2025, Maxime Ripard <mripard@xxxxxxxxxx> wrote:
>> > On Tue, Mar 25, 2025 at 11:16:47AM +0200, Jani Nikula wrote:
>> >> On Sat, 22 Mar 2025, devbrones <jonas.cronholm@xxxxxxxxxxxxxx> wrote:
>> >> > This fixes a bug where some Playstation VR Headsets would not be assigned
>> >> > the EDID_QUIRK_NON_DESKTOP quirk, causing them to be inaccessible by
>> >> > certain software under Wayland.
>> >> 
>> >> Please file a bug over at [1], and attach the EDID on that bug, so we
>> >> have some clue what's going on.
>> >>
>> >> [1] https://gitlab.freedesktop.org/drm/misc/kernel/-/issues/new
>> >
>> > I'd rather have them in the commit log. Nobody uses gitlab issues for
>> > drm-misc, and those kind of issues are just lingering around and
>> > becoming stale.
>> 
>> For this one, it's fine as long as we preserve the raw EDID for
>> posterity. Unless the EDID does indicate VR and we need to dig deeper,
>> that is.
>
> What I was trying to say is if "posterity" means "a forever open issue
> in drm-misc", then no, sorry, that doesn't work for me.

I want to check the EDID before we merge the quirk.

If the EDID does not indicate VR, we can merge. I want the EDID
preserved so we can track them down later if we need to drop or modify
the quirks.

If the EDID does indicate VR, either the quirk is unnecessary or there's
a bug somewhere. This requires further debugging, and we must not merge
the quirk.


BR,
Jani.


-- 
Jani Nikula, Intel