RE: [EXTERNAL] Re: [PATCH net] net: mana: Switch to page pool for jumbo frames

[Haiyang Zhang]

> -----Original Message-----
> From: Jakub Kicinski <kuba@xxxxxxxxxx>
> Sent: Tuesday, March 25, 2025 12:14 PM
> To: Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>
> Cc: linux-hyperv@xxxxxxxxxxxxxxx; netdev@xxxxxxxxxxxxxxx; Dexuan Cui
> <decui@xxxxxxxxxxxxx>; stephen@xxxxxxxxxxxxxxxxxx; KY Srinivasan
> <kys@xxxxxxxxxxxxx>; Paul Rosswurm <paulros@xxxxxxxxxxxxx>;
> olaf@xxxxxxxxx; vkuznets <vkuznets@xxxxxxxxxx>; davem@xxxxxxxxxxxxx;
> wei.liu@xxxxxxxxxx; edumazet@xxxxxxxxxx; pabeni@xxxxxxxxxx;
> leon@xxxxxxxxxx; Long Li <longli@xxxxxxxxxxxxx>;
> ssengar@xxxxxxxxxxxxxxxxxxx; linux-rdma@xxxxxxxxxxxxxxx;
> daniel@xxxxxxxxxxxxx; john.fastabend@xxxxxxxxx; bpf@xxxxxxxxxxxxxxx;
> ast@xxxxxxxxxx; hawk@xxxxxxxxxx; tglx@xxxxxxxxxxxxx;
> shradhagupta@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> stable@xxxxxxxxxxxxxxx
> Subject: [EXTERNAL] Re: [PATCH net] net: mana: Switch to page pool for
> jumbo frames
> 
> On Fri, 21 Mar 2025 18:04:35 -0700 Haiyang Zhang wrote:
> > Since commit 8218f62c9c9b ("mm: page_frag: use initial zero offset for
> > page_frag_alloc_align()"), the netdev_alloc_frag() no longer works for
> > fragsz > PAGE_SIZE. And, this behavior is by design.
> 
> This is inaccurate, AFAIU. The user of frag allocator with fragsz >
> PAGE_SIZE has _always_ been incorrect. It's just that it fails in
> a more obvious way now? Please correct the commit message.

Yes. I will correct the msg.