Re: [PATCH v8 1/6] bits: add comments and newlines to #if, #else and #endif directives

From: Andy Shevchenko
Date: Tue Mar 25 2025 - 12:22:05 EST


On Wed, Mar 26, 2025 at 12:59:56AM +0900, Vincent Mailhol via B4 Relay wrote:
> From: Vincent Mailhol <mailhol.vincent@xxxxxxxxxx>
>
> This is a preparation for the upcoming GENMASK_U*() and BIT_U*()
> changes. After introducing those new macros, there will be a lot of
> scrolling between the #if, #else and #endif.
>
> Add a comment to the #else and #endif preprocessor macros to help keep
> track of which context we are in. Also, add new lines to better
> visually separate the non-asm and asm sections.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Thanks!

--
With Best Regards,
Andy Shevchenko