RE: [EXTERNAL] Re: [PATCH 2/3] net: mana: Implement set_link_ksettings in ethtool for speed

From: Haiyang Zhang
Date: Tue Mar 25 2025 - 15:54:40 EST




> -----Original Message-----
> From: Jakub Kicinski <kuba@xxxxxxxxxx>
> Sent: Tuesday, March 25, 2025 3:22 PM
> To: Andrew Lunn <andrew@xxxxxxx>
> Cc: Erni Sri Satya Vennela <ernis@xxxxxxxxxxxxxxxxxxx>; KY Srinivasan
> <kys@xxxxxxxxxxxxx>; Haiyang Zhang <haiyangz@xxxxxxxxxxxxx>;
> wei.liu@xxxxxxxxxx; Dexuan Cui <decui@xxxxxxxxxxxxx>;
> andrew+netdev@xxxxxxx; davem@xxxxxxxxxxxxx; edumazet@xxxxxxxxxx;
> pabeni@xxxxxxxxxx; Long Li <longli@xxxxxxxxxxxxx>; Konstantin Taranov
> <kotaranov@xxxxxxxxxxxxx>; horms@xxxxxxxxxx; brett.creeley@xxxxxxx;
> surenb@xxxxxxxxxx; schakrabarti@xxxxxxxxxxxxxxxxxxx;
> kent.overstreet@xxxxxxxxx; shradhagupta@xxxxxxxxxxxxxxxxxxx;
> erick.archer@xxxxxxxxxxx; rosenp@xxxxxxxxx; linux-hyperv@xxxxxxxxxxxxxxx;
> netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-
> rdma@xxxxxxxxxxxxxxx
> Subject: [EXTERNAL] Re: [PATCH 2/3] net: mana: Implement
> set_link_ksettings in ethtool for speed
>
> On Tue, 25 Mar 2025 18:52:40 +0100 Andrew Lunn wrote:
> > Using TC would be more natural in this case. The user action is to
> > remove the TC filter and that should set it back to unlimited.
>
> better still - net shapers

Thank you, Andrew & Jakub:
Sure, there are many (better) ways to control/shape the traffic.

This patch is just to support the ethtool option for the speed.
And seems there is no option on ethtool to reset NIC to the default
speed?

- Haiyang