Re: [EXTERNAL] Re: [PATCH 2/3] net: mana: Implement set_link_ksettings in ethtool for speed

From: Andrew Lunn
Date: Tue Mar 25 2025 - 15:59:36 EST


> This patch is just to support the ethtool option for the speed.
> And seems there is no option on ethtool to reset NIC to the default
> speed?

There is no such thing as default speed. Speed is either:

1) Negotiated with the link partner, picking the highest speed link
modes both partners support

2) Forced to a specific speed, based on one of the link modes the
interfaces supports.

Since you don't have link modes, you are abusing the API. You should
choose a different API which actually fits what you are doing,
configuring a leaky bucket shaper.

Andrew