Re: [PATCH v8 4/7] can: Add Nuvoton NCT6694 CANFD support

[Ming Yu]

Marc Kleine-Budde <mkl@xxxxxxxxxxxxxx> 於 2025年3月17日 週一 下午5:21寫道：
>
> > > > +     priv->can.clock.freq = can_clk;
> > > > +     priv->can.bittiming_const = &nct6694_can_bittiming_nominal_const;
> > > > +     priv->can.data_bittiming_const = &nct6694_can_bittiming_data_const;
> > > > +     priv->can.do_set_mode = nct6694_can_set_mode;
> > > > +     priv->can.do_get_berr_counter = nct6694_can_get_berr_counter;
> > > > +     priv->can.ctrlmode_supported = CAN_CTRLMODE_LOOPBACK |
> > > > +             CAN_CTRLMODE_LISTENONLY | CAN_CTRLMODE_BERR_REPORTING |
> > > > +             CAN_CTRLMODE_FD | CAN_CTRLMODE_FD_NON_ISO;
> > >
> > > Does your device run in CAN-FD mode all the time? If so, please use
> > > can_set_static_ctrlmode() to set it after priv->can.ctrlmode_supported
> > > and remove CAN_CTRLMODE_FD from ctrlmode_supported.
> > >
> >
> > Our device is designed to allow users to dynamically switch between
> > Classical CAN and CAN-FD mode via ip link set ... fd on/off.
> > Therefore, CAN_CTRLMODE_FD needs to remain in ctrlmode_supported, and
> > can_set_static_ctrlmode() is not suitable in this case.
> > Please let me know if you have any concerns about this approach.
>
> Where do you evaluate if the user has configured CAN_CTRLMODE_FD or not?
>

Sorry, I was previously confused about our device's control mode. I
will use can_set_static_ctrlmode() to set CAN_FD mode in the next
patch.


Thanks,
Ming