Re: [PATCH 12/34] mfd: sec: add support for S2MPG10 PMIC
From: André Draszik
Date: Wed Mar 26 2025 - 05:35:30 EST
On Wed, 2025-03-26 at 08:22 +0100, Krzysztof Kozlowski wrote:
> On 23/03/2025 23:39, André Draszik wrote:
> > Add support for Samsung's S2MPG10 PMIC, which is a Power Management IC
> > for mobile applications with buck converters, various LDOs, power
> > meters, RTC, clock outputs, and additional GPIOs interfaces.
> >
> > Contrary to existing Samsung S2M series PMICs supported, communication
> > is not via I2C, but via the Samsung ACPM firmware.
> >
> > This commit adds the core driver.
> >
> > Signed-off-by: André Draszik <andre.draszik@xxxxxxxxxx>
> >
> > ---
> > Checkpatch suggests to update MAINTAINERS, but the new file is covered
> > already due to using a wildcard.
> > ---
>
> I did a quick look and seems fine, but I suspect small rework when PMIC
> becames child of ACPM, so full review later.
Thanks Krzysztof! And yes, there'll be a small change to support that approach
instead.
Cheers,
Andre'