Re: [PATCH v4 0/2] iio: rzg2l_adc: Cleanups for rzg2l_adc driver

From: Claudiu Beznea
Date: Thu Mar 27 2025 - 12:35:12 EST


Hi, Jonathan,

On 27.03.2025 17:38, Jonathan Cameron wrote:
> On Mon, 24 Mar 2025 14:26:25 +0200
> Claudiu <claudiu.beznea@xxxxxxxxx> wrote:
>
>> From: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
>>
>> Hi,
>>
>> Series adds some cleanups for the RZ/G2L ADC driver after the support
>> for the RZ/G3S SoC.
>
> This doesn't address Dmitry's comment or highlight the outstanding
> question he had to Greg KH on v3.
> I appreciate you want to get this fixed but I'd rather we got
> it 'right' first time!

My bad. As there was no input on platform bus patch I though this is not
the desired way of going forward. Sorry for that.

>
> Also, please make sure to +CC anyone who engaged with an earlier version.

Ok, will do it.

>
> For reference of Greg if he sees this, Dmitry was expressing view that
> the fix belongs in the bus layer not the individual drivers.
> FWIW that feels like the right layer to me as well.

To me, too.

Thank you,
Claudiu

>
> https://lore.kernel.org/all/Z8k8lDxA53gUJa0n@xxxxxxxxxx/#t
>
> Jonathan
>
>
>
>>
>> Thank you,
>> Claudiu Beznea
>>
>> Changes in v4:
>> - open the devres group in its own function and rename the
>> rzg2l_adc_probe() to rzg2l_adc_probe_helper() to have simpler code
>> - collected tags
>>
>> Changes in v3:
>> - in patch 2/2 use a devres group for all the devm resources
>> acquired in the driver's probe
>>
>> Changes in v2:
>> - updated cover letter
>> - collected tags
>> - updated patch 1/2 to drop devres APIs from the point the
>> runtime PM is enabled
>>
>> Claudiu Beznea (2):
>> iio: adc: rzg2l_adc: Open a devres group
>> iio: adc: rzg2l: Cleanup suspend/resume path
>>
>> drivers/iio/adc/rzg2l_adc.c | 67 +++++++++++++++++++++++++------------
>> 1 file changed, 45 insertions(+), 22 deletions(-)
>>
>