Re: [PATCH v2 1/1] rust: macros: Fix macro referencing core and kernel crates v2
From: Benno Lossin
Date: Fri Mar 28 2025 - 17:50:45 EST
On Fri Mar 28, 2025 at 7:03 PM CET, Igor Korotin wrote:
> Update macros to always use absolute paths for crates `core` and `kernel`.
> This guarantees that macros will not pick up user-defined crates `core`
> or `kernel` by accident.
The crates are not user-defineable. Your initial message was correct in
that the user can define *modules* that have precedence over the crates
`core` and `kernel`.
> Changes since v1:
> - Fixed paths in auto-generated code.
The changelog shouldn't be in the commit message. Instead place it below
the `---`, but before the change stats.
> Suggested-by: Benno Lossin <benno.lossin@xxxxxxxxx>
> Closes: https://github.com/Rust-for-Linux/linux/issues/1150
> Signed-off-by: Igor Korotin <igor.korotin@xxxxxxxxx>
> ---
(put the changelog here)
---
Cheers,
Benno
> rust/ffi.rs | 2 +-
> rust/kernel/device.rs | 2 +-
> rust/kernel/device_id.rs | 4 ++--
> rust/kernel/kunit.rs | 8 ++++----
> rust/kernel/static_assert.rs | 4 ++--
> rust/kernel/str.rs | 4 ++--
> rust/macros/kunit.rs | 22 +++++++++++-----------
> rust/macros/lib.rs | 6 +++---
> rust/macros/module.rs | 31 ++++++++++++++++---------------
> scripts/rustdoc_test_builder.rs | 6 +++---
> scripts/rustdoc_test_gen.rs | 16 ++++++++++------
> 11 files changed, 55 insertions(+), 50 deletions(-)