Re: [PATCH v2 1/1] rust: macros: Fix macro referencing core and kernel crates v2

[Miguel Ojeda]

On Fri, Mar 28, 2025 at 7:05 PM Igor Korotin <igor.korotin@xxxxxxxxx> wrote:
>
> Update macros to always use absolute paths for crates `core` and `kernel`.
> This guarantees that macros will not pick up user-defined crates `core`
> or `kernel` by accident.
>
> Changes since v1:
> - Fixed paths in auto-generated code.
>
> Suggested-by: Benno Lossin <benno.lossin@xxxxxxxxx>
> Closes: https://github.com/Rust-for-Linux/linux/issues/1150
> Signed-off-by: Igor Korotin <igor.korotin@xxxxxxxxx>

Thanks for the patch!

A few procedural notes:

  - The title has a v2 at the end -- please do not add versions in the
title of the commit, the "[PATCH v2...] is enough for that :)

  - The "Changes since v1" should be part of the non-commit-log part,
i.e. after the `---` line below.

  - If you send a single patch, then you don't need to add a cover
letter necessarily (typically you just use the place after `---` in
the patch).

  - Speaking of the cover letter, it seems like the 0/1 patch looks
like a reply to Benno rather than an actual cover letter, and does not
follow the usual cover letter format. That is quite confusing.

  - You should send the patch to the relevant maintainers and
reviewers -- you can use `scripts/get_maintainer.pl` or something like
https://rust-for-linux.com/contributing#submitting-patches.

Please take a look at another v2 to see how people normally do it. For
instance, this recent one looks fairly standard:

    https://lore.kernel.org/rust-for-linux/20250325133352.441425-1-andrewjballance@xxxxxxxxx/

Thanks!

Cheers,
Miguel