Re: [PATCH 1/5] scsi: hisi_sas: Add host_tagset_enable module param for v3 hw

[John Garry]

On 29/03/2025 07:32, Yihang Li wrote:

+

> From: Xingui Yang<yangxingui@xxxxxxxxxx>
>
> After driver exposes all HW queues and application submits IO to multiple
> queues in parallel, if NCQ and non-NCQ commands are mixed to sata disk,
> ata_qc_defer() causes non-NCQ commands to be requeued and possibly repeated
> forever.

I don't think that it is a good idea to mask out bugs with module 
parameters.

Was this the same libata/libsas issue reported some time ago?

> Add host_tagset_enable module parameter to expose multiple queues
> for v3 hw.
>
> Signed-off-by: Xingui Yang<yangxingui@xxxxxxxxxx>
> Signed-off-by: Yihang Li<liyihang9@xxxxxxxxxx>