Re: [PATCH] rust: Fix enabling Rust and building with GCC for LoongArch
From: Huacai Chen
Date: Sat Mar 29 2025 - 04:53:10 EST
Hi, Miguel,
On Sat, Mar 29, 2025 at 12:15 AM Miguel Ojeda
<miguel.ojeda.sandonis@xxxxxxxxx> wrote:
>
> On Tue, Mar 4, 2025 at 10:12 AM Huacai Chen <chenhuacai@xxxxxxxxxx> wrote:
> >
> > Don't rely on default behavior, things may change in future.
> > Acked-by: Huacai Chen <chenhuacai@xxxxxxxxxxx>
>
> I was pinged about this one -- are you picking this one through your tree?
OK, I wll pick it to the loongarch tree, thanks.
Huacai
>
> I didn't test it, but the change seems safe to me for other
> architectures that we have at the moment, since they don't seem to set
> any of those three from a quick look, so:
>
> Acked-by: Miguel Ojeda <ojeda@xxxxxxxxxx>
>
> In any case, the usual question for these "skipped flags" is whether
> they could affect the output of `bindgen`, i.e. could they modify
> layouts somehow?
>
> Also, it would be nice to mention a bit more what was the build error
> and the GCC version in the commit message.
>
> Finally, regarding the Cc: stable, I guess that means 6.12+ since it
> is the first LTS with loongarch64, right?
>
> Thanks!
>
> Cheers,
> Miguel