Re: [PATCH 2/9] x86/nmi: Consolidate NMI panic variables

[Sohil Mehta]

On 3/31/2025 6:06 PM, Huang, Kai wrote:

>>> Ah I didn't know this series was merged.  I think I'll stop looking at it.  :-)
>>
>> Your review comments have been useful. Please continue reviewing if you
>> can. You found an issue in patch 1 that both of us missed.
>>
> 
> I just did.  I didn't find anything apart from one thing that I _think_ it might
> be helpful to mention another commit in the changelog of patch 5 "x86/nmi: Fix
> comment in unknown NMI handling".
> 

Kai, I feel the additional commit is indirectly implied. I am inclined
to leave the changelog as-is unless you feel strongly about it.

Thank you for the reviews. Really appreciate it!

Ingo, there are 2 main changes from the patches in tip:x86/nmi.

1) As pointed out by Kai, there is a minor oversight in patch 1 on my
part. The header files aren't strictly ordered. There needs to be a
single line change to keep them alphabetically ordered.

2) As discussed in patch 7, the title for split-off patch is incorrect.

If you prefer, I can generate a new series based on the patches you have
in tip to save you the extra effort again. Or I can generate a single
additional patch on top if you want.

OTOH, feel free to make the changes yourself and include my signoffs.