Re: [PATCH 2/9] x86/nmi: Consolidate NMI panic variables

From: Huang, Kai
Date: Tue Apr 01 2025 - 04:09:01 EST


On Mon, 2025-03-31 at 22:46 -0700, Sohil Mehta wrote:
> On 3/31/2025 6:06 PM, Huang, Kai wrote:
>
> > > > Ah I didn't know this series was merged.  I think I'll stop looking at it.  :-)
> > >
> > > Your review comments have been useful. Please continue reviewing if you
> > > can. You found an issue in patch 1 that both of us missed.
> > >
> >
> > I just did.  I didn't find anything apart from one thing that I _think_ it might
> > be helpful to mention another commit in the changelog of patch 5 "x86/nmi: Fix
> > comment in unknown NMI handling".
> >
>
> Kai, I feel the additional commit is indirectly implied. I am inclined
> to leave the changelog as-is unless you feel strongly about it.

Sure np to me.