Re: [PATCH] crypto: Kconfig - correct references in config CRYPTO_HKDF

[Herbert Xu]

On Tue, Apr 01, 2025 at 02:13:54PM +0200, Lukas Bulwahn wrote:
>
> diff --git a/crypto/Kconfig b/crypto/Kconfig
> index dbf97c4e7c59..f601a4ec6d1a 100644
> --- a/crypto/Kconfig
> +++ b/crypto/Kconfig
> @@ -143,8 +143,8 @@ config CRYPTO_ACOMP
>  
>  config CRYPTO_HKDF
>  	tristate
> -	select CRYPTO_SHA256 if !CONFIG_CRYPTO_MANAGER_DISABLE_TESTS
> -	select CRYPTO_SHA512 if !CONFIG_CRYPTO_MANAGER_DISABLE_TESTS
> +	select CRYPTO_SHA256 if !CRYPTO_MANAGER_DISABLE_TESTS
> +	select CRYPTO_SHA512 if !CRYPTO_MANAGER_DISABLE_TESTS

Why not just drop CRYPTO_MANAGER_DISABLE_TESTS and select the
SHA algorithms unconditionally?

>  	select CRYPTO_HASH2

Nobody should select HASH2.  Just drop it since it's implied
by SHA256/SHA512.

Cheers,
-- 
Email: Herbert Xu <herbert@xxxxxxxxxxxxxxxxxxx>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt