Re: [PATCH] crypto: Kconfig - correct references in config CRYPTO_HKDF
From: Hannes Reinecke
Date: Wed Apr 02 2025 - 02:05:25 EST
On 4/1/25 14:16, Herbert Xu wrote:
On Tue, Apr 01, 2025 at 02:13:54PM +0200, Lukas Bulwahn wrote:
diff --git a/crypto/Kconfig b/crypto/Kconfig
index dbf97c4e7c59..f601a4ec6d1a 100644
--- a/crypto/Kconfig
+++ b/crypto/Kconfig
@@ -143,8 +143,8 @@ config CRYPTO_ACOMP
config CRYPTO_HKDF
tristate
- select CRYPTO_SHA256 if !CONFIG_CRYPTO_MANAGER_DISABLE_TESTS
- select CRYPTO_SHA512 if !CONFIG_CRYPTO_MANAGER_DISABLE_TESTS
+ select CRYPTO_SHA256 if !CRYPTO_MANAGER_DISABLE_TESTS
+ select CRYPTO_SHA512 if !CRYPTO_MANAGER_DISABLE_TESTS
Why not just drop CRYPTO_MANAGER_DISABLE_TESTS and select the
SHA algorithms unconditionally?
Fine with me. I was just trying to follow precedent here when creating
the original patch.
Cheers,
Hannes
--
Dr. Hannes Reinecke Kernel Storage Architect
hare@xxxxxxx +49 911 74053 688
SUSE Software Solutions GmbH, Frankenstr. 146, 90461 Nürnberg
HRB 36809 (AG Nürnberg), GF: I. Totev, A. McDonald, W. Knoblich