Re: [PATCH] perf tests switch-tracking: Fix timestamp comparison
From: Leo Yan
Date: Wed Apr 02 2025 - 05:06:05 EST
On Tue, Apr 01, 2025 at 12:54:12PM -0700, Ian Rogers wrote:
> On Tue, Apr 1, 2025 at 2:14 AM Leo Yan <leo.yan@xxxxxxx> wrote:
> >
> > On Mon, Mar 31, 2025 at 01:18:31PM -0700, Ian Rogers wrote:
> >
> > [...]
> >
> > > I'm reminded of a Java check I wrote for this:
> >
> > Nice short article.
> >
> > > In clang -Wshorten-64-to-32 looks to cover this. I'll see if we can
> > > clean those warnings up a bit.
> >
> > I checked a bit and seems GCC has no this flag, but it makes sense for
> > me to enable the flag for Clang.
> >
> > > Reviewed-by: Ian Rogers <irogers@xxxxxxxxxx>
> >
> > Thanks a lot, Ian.
>
> I made a small variation to the change in:
> https://lore.kernel.org/lkml/20250401182347.3422199-10-irogers@xxxxxxxxxx/
> to avoid a subtract and just directly compare the values.
Fine by me. I reviewed your patch, the direct comparing LGTM.
Thanks,
Leo