Re: [PATCH v2 14/19] mtd: spinand: Use more specific naming for the (quad) program load op
From: Miquel Raynal
Date: Thu Apr 03 2025 - 06:23:19 EST
On 03/04/2025 at 11:00:46 +01, Tudor Ambarus <tudor.ambarus@xxxxxxxxxx> wrote:
> On 4/3/25 10:19 AM, Miquel Raynal wrote:
>> SPI operations have been initially described through macros implicitly
>> implying the use of a single SPI SDR bus. Macros for supporting dual and
>> quad I/O transfers have been added on top, generally inspired by vendor
>> naming, followed by DTR operations. Soon we might see octal
>> and even octal DTR operations as well (including the opcode byte).
>>
>> Let's clarify what the macro really means by describing the expected bus
>> topology in the (quad) program load macro name.
>>
>> While at modifying it, better add the missing_ OP suffix to align with
>> all the other macros of the same kind.
>>
>> Acked-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx>
>> Reviewed-by: Tudor Ambarus <tudor.ambarus@xxxxxxxxxx>
>
> I don't remember giving R-b on this, not seeing it on ml as well, so
> please drop it when applying.
>
> I used Acked-by and not R-b because I wanted to signify that I'm OK with
> the general idea of the patches and that I'm OK with them landing, but I
> may not have reviewed it as thoroughly as if a Reviewed-by: was
> provided. Please use only the tags that I sent. And if by mistake I sent
> both A-b and R-b, use just the latter. Thanks!
I use b4 for collecting tags, but yeah that's strange.
I will use your Acked-by here.