Re: [PATCH v4] f2fs: prevent the current section from being selected as a victim during GC
From: kernel test robot
Date: Thu Apr 03 2025 - 11:11:57 EST
Hi yohan.joung,
kernel test robot noticed the following build errors:
[auto build test ERROR on jaegeuk-f2fs/dev-test]
[also build test ERROR on jaegeuk-f2fs/dev linus/master v6.14 next-20250403]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/yohan-joung/f2fs-prevent-the-current-section-from-being-selected-as-a-victim-during-GC/20250403-151057
base: https://git.kernel.org/pub/scm/linux/kernel/git/jaegeuk/f2fs.git dev-test
patch link: https://lore.kernel.org/r/20250403071016.2940-1-yohan.joung%40sk.com
patch subject: [PATCH v4] f2fs: prevent the current section from being selected as a victim during GC
config: i386-buildonly-randconfig-005-20250403 (https://download.01.org/0day-ci/archive/20250403/202504032206.xzJoHkRX-lkp@xxxxxxxxx/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250403/202504032206.xzJoHkRX-lkp@xxxxxxxxx/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@xxxxxxxxx>
| Closes: https://lore.kernel.org/oe-kbuild-all/202504032206.xzJoHkRX-lkp@xxxxxxxxx/
All errors (new ones prefixed by >>):
In file included from fs/f2fs/checkpoint.c:20:
fs/f2fs/segment.h: In function '__set_test_and_free':
>> fs/f2fs/segment.h:480:81: error: macro "GET_SEC_FROM_SEG" requires 2 arguments, but only 1 given
480 | if (GET_SEC_FROM_SEG(sbi->next_victim_seg[BG_GC]) == secno)
| ^
fs/f2fs/segment.h:105: note: macro "GET_SEC_FROM_SEG" defined here
105 | #define GET_SEC_FROM_SEG(sbi, segno) \
|
>> fs/f2fs/segment.h:480:37: error: 'GET_SEC_FROM_SEG' undeclared (first use in this function)
480 | if (GET_SEC_FROM_SEG(sbi->next_victim_seg[BG_GC]) == secno)
| ^~~~~~~~~~~~~~~~
fs/f2fs/segment.h:480:37: note: each undeclared identifier is reported only once for each function it appears in
fs/f2fs/segment.h:483:81: error: macro "GET_SEC_FROM_SEG" requires 2 arguments, but only 1 given
483 | if (GET_SEC_FROM_SEG(sbi->next_victim_seg[FG_GC]) == secno)
| ^
fs/f2fs/segment.h:105: note: macro "GET_SEC_FROM_SEG" defined here
105 | #define GET_SEC_FROM_SEG(sbi, segno) \
|
vim +/GET_SEC_FROM_SEG +480 fs/f2fs/segment.h
458
459 static inline void __set_test_and_free(struct f2fs_sb_info *sbi,
460 unsigned int segno, bool inmem)
461 {
462 struct free_segmap_info *free_i = FREE_I(sbi);
463 unsigned int secno = GET_SEC_FROM_SEG(sbi, segno);
464 unsigned int start_segno = GET_SEG_FROM_SEC(sbi, secno);
465 unsigned int next;
466 unsigned int usable_segs = f2fs_usable_segs_in_sec(sbi);
467
468 spin_lock(&free_i->segmap_lock);
469 if (test_and_clear_bit(segno, free_i->free_segmap)) {
470 free_i->free_segments++;
471
472 if (!inmem && IS_CURSEC(sbi, secno))
473 goto skip_free;
474 next = find_next_bit(free_i->free_segmap,
475 start_segno + SEGS_PER_SEC(sbi), start_segno);
476 if (next >= start_segno + usable_segs) {
477 if (test_and_clear_bit(secno, free_i->free_secmap)) {
478 free_i->free_sections++;
479
> 480 if (GET_SEC_FROM_SEG(sbi->next_victim_seg[BG_GC]) == secno)
481 sbi->next_victim_seg[BG_GC] = NULL_SEGNO;
482
483 if (GET_SEC_FROM_SEG(sbi->next_victim_seg[FG_GC]) == secno)
484 sbi->next_victim_seg[FG_GC] = NULL_SEGNO;
485 }
486 }
487 }
488 skip_free:
489 spin_unlock(&free_i->segmap_lock);
490 }
491
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki