Re: [PATCHSET sched_ext/for-6.16] sched_ext: Cleanup "ops" usage in symbols

[Andrea Righi]

Hi Tejun,

On Thu, Apr 03, 2025 at 12:49:42PM -1000, Tejun Heo wrote:
> The tag "ops" is used for two different purposes. First, to indicate that
> the entity is directly related to the operations such as flags carried in
> sched_ext_ops. Second, to indicate that the entity applies to something
> global such as enable or bypass states. The second usage is historical and
> causes confusion rather than clarifying anything. For example,
> scx_ops_enable_state enums are named SCX_OPS_* and thus conflict with
> scx_ops_flags.

We should probably rename also SCX_OPS_TASK_ITER_BATCH, which is not
related to sched_ext_ops as well.

Apart than that and the other comment about scx_error(), this looks like a
good cleanup.

Acked-by: Andrea Righi <arighi@xxxxxxxxxx>

Thanks,
-Andrea

> 
> This inconsistency will become more noticeable with the planned multiple
> scheduler support. Clean them up in preparation.
> 
> This patchset is on top of the current linus#master e8b471285262 ("Merge tag
> 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rmk/linux") and
> contains the following patches:
> 
>  0001-sched_ext-Drop-ops-from-scx_ops_enable_state-and-fri.patch
>  0002-sched_ext-Drop-ops-from-scx_ops_helper-scx_ops_enabl.patch
>  0003-sched_ext-Drop-ops-from-scx_ops_bypass-scx_ops_breat.patch
>  0004-sched_ext-Drop-ops-from-scx_ops_exit-scx_ops_error-a.patch
>  0005-sched_ext-Drop-ops-from-scx_ops_-init-exit-enable-di.patch
> 
> which are also available in the following git branch:
> 
>  git://git.kernel.org/pub/scm/linux/kernel/git/tj/sched_ext.git scx-drop-ops-from-names
> 
> diffstat follows.
> 
>  kernel/sched/ext.c                |  458 ++++++++++++++++++--------------------
>  kernel/sched/ext_idle.c           |   20 -
>  kernel/sched/sched.h              |    4
>  tools/sched_ext/scx_show_state.py |   14 -
>  4 files changed, 239 insertions(+), 257 deletions(-)
> 
> --
> tejun
>