Re: [PATCHSET sched_ext/for-6.16] sched_ext: Cleanup "ops" usage in symbols
From: Tejun Heo
Date: Fri Apr 04 2025 - 14:54:18 EST
On Fri, Apr 04, 2025 at 09:41:32AM +0200, Andrea Righi wrote:
> Hi Tejun,
>
> On Thu, Apr 03, 2025 at 12:49:42PM -1000, Tejun Heo wrote:
> > The tag "ops" is used for two different purposes. First, to indicate that
> > the entity is directly related to the operations such as flags carried in
> > sched_ext_ops. Second, to indicate that the entity applies to something
> > global such as enable or bypass states. The second usage is historical and
> > causes confusion rather than clarifying anything. For example,
> > scx_ops_enable_state enums are named SCX_OPS_* and thus conflict with
> > scx_ops_flags.
>
> We should probably rename also SCX_OPS_TASK_ITER_BATCH, which is not
> related to sched_ext_ops as well.
>
> Apart than that and the other comment about scx_error(), this looks like a
> good cleanup.
>
> Acked-by: Andrea Righi <arighi@xxxxxxxxxx>
Applied 1-5 to sched_ext/for-6.16. Will address the suggestions in separate
patches.
Thanks.
--
tejun