Re: [PATCH v1] platform/chrome: cros_ec_proto: allow to build as module

[Sławomir Rosek]

On Wed, Apr 2, 2025 at 10:24 AM Tzung-Bi Shih <tzungbi@xxxxxxxxxx> wrote:
>
> On Fri, Mar 28, 2025 at 01:26:12PM +0000, Slawomir Rosek wrote:
> > This allows to build ChromeOS EC communication protocol helpers as
>
> s/This allows/Allow/.

I will fix that, thanks.

>
> > kernel module which is particularly useful for Android GKI (Generic
> > Kernel Image) configuration. With this change the ChromeOS Platform
> > (CONFIG_CHROME_PLATFORMS=y) can be enabled directly from the vendor
> > kconfig fragment whithout additional configuration in gki_defconfig.
>
> Does it work?  CROS_EC_PROTO is "selected" by other Kconfigs.  Wouldn't it
> be either =y or =n?

Yes, it is already used by android 6.6 and 6.12 kernels. The
CROS_EC_PROTO is used only by other tristates so =m propagates
properly.