Re: [PATCH v9 3/4] arm64: defconfig: add S32G RTC module support

[Ciprian Marian Costea]

On 4/4/2025 11:53 AM, Alexandre Belloni wrote:
> On 04/04/2025 10:19:56+0300, Ciprian Marian Costea wrote:
> > On 4/4/2025 10:15 AM, Krzysztof Kozlowski wrote:
> > > On 04/04/2025 08:24, Ciprian Marian Costea wrote:
> > > > On 4/4/2025 9:17 AM, Krzysztof Kozlowski wrote:
> > > > > On 03/04/2025 12:33, Ciprian Costea wrote:
> > > > > > From: Ciprian Marian Costea <ciprianmarian.costea@xxxxxxxxxxx>
> > > > > >
> > > > > > The RTC hardware module present on S32G based SoCs tracks clock time
> > > > > > during system suspend and it is used as a wakeup source on S32G2/S32G3
> > > > > > architecture.
> > > > > Which boards are using it? I don't see any DTS (nowhere), so I do not
> > > > > see single reason for this patch.
> > > > >
> > > > > Best regards,
> > > > > Krzysztof
> > > >
> > > > The RTC module is used by all the currently supported S32G2/S32G3
> > > > boards, so currently they are: S32G274A-EVB, S32G274A-RDB2, S32G399A-RDB3.
> > >
> > > I don't think so. I looked at these DTS and there is no RTC.
> > >
> > > > I do see your point in the fact that this driver should be enabled as
> > > > module only after platforms are actually using it.
> > >
> > > No, post the user. I don't see the point of sending defconfig patch with
> > > RTC patchset anyway. That's different subsystem.
> > >
> > > > So, would it be better for me to send a V10 in this series with the DTS
> > > > patch added ?
> > >
> > > No, separate patchsets.
> >
> > Ok. I will send out a V10 in which I will drop this current patch from the
> > patchset. Also, I will send the DTS patch which adds S32G274A-EVB,
> > S32G274-RDB2 and S32G399A-RDB3 usage of the RTC after this patchset gets
> > accepted.
>
> I don't need V10, I can apply V9 without 3/4 and 4/4

Ok. Thanks for letting me know.

Ciprian

> > Best Regards,
> > Ciprian
> >
> > > Best regards,
> > > Krzysztof