Re: [PATCH net v2 6/7] net: hibmcge: fix not restore rx pause mac addr after reset issue

From: Jakub Kicinski
Date: Fri Apr 04 2025 - 10:58:15 EST


On Thu, 3 Apr 2025 21:53:10 +0800 Jijie Shao wrote:
> In normal cases, the driver must ensure that the value
> of rx pause mac addr is the same as the MAC address of
> the network port. This ensures that the driver can
> receive pause frames whose destination address is
> the MAC address of the network port.

I thought "in normal cases" pause frames use 01:80:C2:00:00:01
as the destination address!?

Are you sure this patch is not a misunderstanding, and the issue
is already fixed by patch 2?

> Currently, the rx pause addr does not restored after reset.
>
> The index of the MAC address of the host is always 0.
> Therefore, this patch sets rx pause addr to
> the MAC address with index 0.
--
pw-bot: cr