Re: [PATCH net v2 6/7] net: hibmcge: fix not restore rx pause mac addr after reset issue

[Jijie Shao]

on 2025/4/4 22:58, Jakub Kicinski wrote:
> On Thu, 3 Apr 2025 21:53:10 +0800 Jijie Shao wrote:
> > In normal cases, the driver must ensure that the value
> > of rx pause mac addr is the same as the MAC address of
> > the network port. This ensures that the driver can
> > receive pause frames whose destination address is
> > the MAC address of the network port.
> I thought "in normal cases" pause frames use 01:80:C2:00:00:01
> as the destination address!?

No, the address set in .ndo_set_mac_address() is used.
01:80:C2:00:00:01 is supported by default. No additional configuration is required.

> Are you sure this patch is not a misunderstanding, and the issue
> is already fixed by patch 2?

It's a different issue. This patch is used to solve the problem that
the configuration is lost after reset.

> > Currently, the rx pause addr does not restored after reset.

Here.

> > The index of the MAC address of the host is always 0.
> > Therefore, this patch sets rx pause addr to
> > the MAC address with index 0.