Re: [PATCH v2 1/2] memcg: Don't generate low/min events if either low/min or elow/emin is 0

From: Waiman Long
Date: Fri Apr 04 2025 - 13:25:47 EST



On 4/4/25 1:12 PM, Tejun Heo wrote:
Hello,

On Thu, Apr 03, 2025 at 09:24:34PM -0400, Waiman Long wrote:
...
The simple and naive fix of changing the operator to ">", however,
changes the memory reclaim behavior which can lead to other failures
as low events are needed to facilitate memory reclaim. So we can't do
that without some relatively riskier changes in memory reclaim.
I'm doubtful using ">" would change reclaim behavior in a meaningful way and
that'd be more straightforward. What do mm people think?

I haven't looked deeply into why that is the case, but test_memcg_low/min tests had other failures when I made this change.

Cheers,
Longman


Thanks.