Re: [PATCH v3 1/2] dt-bindings: mailbox: Add support for bcm74110

From: Krzysztof Kozlowski
Date: Sun Apr 06 2025 - 08:28:12 EST


On 05/04/2025 00:20, justin.chen@xxxxxxxxxxxx wrote:
> +
> +maintainers:
> + - Justin Chen <justin.chen@xxxxxxxxxxxx>
> + - Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
> +
> +description: Broadcom mailbox hardware first introduced with 74110
> +
> +properties:
> + compatible:
> + enum:
> + - brcm,bcm74110-mbox
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + minItems: 1

Third version of patchset, third entirely different code.

Decide finally what is the hardware and send binding matching it.
Hardware did not change last one week three times.

Drop minItems or explain why this is flexible on the same SoC or between
boards using same SoC. You can always point me to upstream DTS, which
would solve many questions.

> + items:
> + - description: RX doorbell and watermark interrupts
> + - description: TX doorbell and watermark interrupts
> +


Best regards,
Krzysztof