Re: [PATCH v3 1/2] dt-bindings: mailbox: Add support for bcm74110

[Justin Chen]

On 4/6/25 5:27 AM, Krzysztof Kozlowski wrote:
> On 05/04/2025 00:20, justin.chen@xxxxxxxxxxxx wrote:
> > +
> > +maintainers:
> > +  - Justin Chen <justin.chen@xxxxxxxxxxxx>
> > +  - Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
> > +
> > +description: Broadcom mailbox hardware first introduced with 74110
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - brcm,bcm74110-mbox
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  interrupts:
> > +    minItems: 1
>
> Third version of patchset, third entirely different code.
>
> Decide finally what is the hardware and send binding matching it.
> Hardware did not change last one week three times.
>
> Drop minItems or explain why this is flexible on the same SoC or between
> boards using same SoC. You can always point me to upstream DTS, which
> would solve many questions.

We do not have an upstream DTS. We have a scripting engine that 
generates a DTS and we distribute DTBs to our customers. The example 
from v2 of my patch was copied from said generated DTS.

Apologies as I navigate through the different yaml keywords here. The HW
isn't changing, I am just struggling with representing the HW using the
different keywords. And the different implications of using said keywords.

Here is what I have for v4.
     items:
       - description: RX doorbell and watermark interrupts
       - description: TX doorbell and watermark interrupts
+    description:
+      RX interrupts are required to notify the host of pending messages. TX
+      interrupts are optional. The TX doorbell interrupt is not used by the
+      host, but watermark interrupts may be used to notify a host 
waiting on
+      a full out queue.

Thanks,
Justin

> > +    items:
> > +      - description: RX doorbell and watermark interrupts
> > +      - description: TX doorbell and watermark interrupts
> > +
>
>
> Best regards,
> Krzysztof