Re: [PATCH net-next v6] net: dlink: add support for reporting stats via `ethtool -S` and `ip -s -s link show`

From: Moon Yeounsu
Date: Mon Apr 07 2025 - 18:58:13 EST


On Mon, Apr 07, 2025 at 10:48:01PM +0200, Andrew Lunn wrote:
> When i see a list like this, it makes me think this should be broken
> up into multiple patches. Ideally you want lots of simple patches
> which are obviously correct.

Would it be appropriate to split this into a patchset, then?
To be honest, this is my first time creating a patchset, so
I'm not entirely sure how to divide it properly.

For now, I'm thinking of splitting it as follows:
1. stat definitions and declarations
2. preprocessor directives (`#ifdef`)
3. `spin_[un]lock_irq()` related changes
4. `get_stats()` implementation
5. `ethtool_ops` implementation

Is it okay to resend the v7 patchset split as above?