Re: [PATCH v2 1/2] dt-bindings: hwmon: pmbus: add lt3074

[Guenter Roeck]

On 2/26/25 00:20, Krzysztof Kozlowski wrote:
> On Tue, Feb 25, 2025 at 09:01:13PM +0800, Cedric Encarnacion wrote:
> > Add Analog Devices LT3074 Ultralow Noise, High PSRR Dropout Linear
> > Regulator.
> >
> > Signed-off-by: Cedric Encarnacion <cedricjustine.encarnacion@xxxxxxxxxx>
> > ---
> >   .../bindings/hwmon/pmbus/adi,lt3074.yaml           | 64 ++++++++++++++++++++++
> >   MAINTAINERS                                        |  7 +++
> >   2 files changed, 71 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/adi,lt3074.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/adi,lt3074.yaml
> > new file mode 100644
> > index 0000000000000000000000000000000000000000..714426fd655a8daa96e15e1f789743f36001ac7a
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/hwmon/pmbus/adi,lt3074.yaml
> > @@ -0,0 +1,64 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/hwmon/pmbus/adi,lt3074.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Analog Devices LT3074 voltage regulator
> > +
> > +maintainers:
> > +  - Cedric Encarnacion <cedricjustine.encarnacion@xxxxxxxxxx>
> > +
> > +description: |
> > +  The LT3074 is a low voltage, ultra-low noise and ultra-fast transient
> > +  response linear regulator. It allows telemetry for input/output voltage,
> > +  output current and temperature through the PMBus serial interface.
> > +
> > +  Datasheet:
> > +    https://www.analog.com/en/products/lt3074.html
> > +
> > +properties:
> > +  compatible:
> > +    enum:
> > +      - adi,lt3074
> > +
> > +  reg:
> > +    maxItems: 1
> > +
> > +  regulators:
> > +    type: object
> > +    description: |
> > +      list of regulators provided by this controller.
>
> You have only one regulator, so drop the "regulators". vout could be
> here, but since you do not have any other resources, I doubt it stands
> on its own either. This is even visible in your DTS - you named the
> device as regulator, so logically this is the regulator. Regulator does
> not have regulators (otherwise they could also have regulators... so
> triple regulator).
>
> hwmon code might need some changes, but that's not really relevant for
> proper hardware description.

With the changes in the hwmon pmbus code now in linux-next, this should
be ready for another revision with non-nested regulator support.

Thanks,
Guenter