Re: [PATCH RFC v2 6/6] pinctrl: Add pin controller driver for AAEON UP boards

From: Thomas Richard
Date: Wed Apr 09 2025 - 10:03:52 EST


On 3/17/25 19:42, Andy Shevchenko wrote:
>> + board_id = (enum upboard_board_id)dmi_id->driver_data;
>> +
>> + switch (board_id) {
>> + case BOARD_UP_APL01:
>> + pctrl->maps = upboard_pinctrl_mapping_up_apl01;
>> + pctrl->nmaps = ARRAY_SIZE(upboard_pinctrl_mapping_up_apl01);
>> + break;
>
> Hmm... This is strange. Seems it has only Apollo Lake in the name while
> the above states that there is UP board support (which is Cherry Trail based).

There is pinctrl code for UP and UP Squared. But I only added mapping
for UP Squared board because it was the easiest board to add (all needed
pinctrl groups and functions are already defined in the Intel pinctrl
driver).
I wanted to focus on the driver itself and the forwarder library, and
send later an other series to add UP board support (with the
corresponding functions/groups in the Intel pinctrl driver).

So yes UP board pinctrl part is unused for now, but everything is ready
to add support for UP board in the future.

Otherwise I can remove UP part if you prefer.

Regards,

Thomas