Re: [PATCH RFC v2 6/6] pinctrl: Add pin controller driver for AAEON UP boards

[Thomas Richard]

On 4/9/25 16:02, Thomas Richard wrote:
> On 3/17/25 19:42, Andy Shevchenko wrote:
>>> +	board_id = (enum upboard_board_id)dmi_id->driver_data;
>>> +
>>> +	switch (board_id) {
>>> +	case BOARD_UP_APL01:
>>> +		pctrl->maps = upboard_pinctrl_mapping_up_apl01;
>>> +		pctrl->nmaps = ARRAY_SIZE(upboard_pinctrl_mapping_up_apl01);
>>> +		break;
>>
>> Hmm... This is strange. Seems it has only Apollo Lake in the name while
>> the above states that there is UP board support (which is Cherry Trail based).
> 
> There is pinctrl code for UP and UP Squared. But I only added mapping
> for UP Squared board because it was the easiest board to add (all needed
> pinctrl groups and functions are already defined in the Intel pinctrl
> driver).
> I wanted to focus on the driver itself and the forwarder library, and
> send later an other series to add UP board support (with the
> corresponding functions/groups in the Intel pinctrl driver).
> 
> So yes UP board pinctrl part is unused for now, but everything is ready
> to add support for UP board in the future.
> 
> Otherwise I can remove UP part if you prefer.

Hi Andy,

I just realized that my wording was incorrect, so let me clarify.

The UP Board [1] (based on Cherry Trail) is not supported at all (its
FPGA is not supported by the MFD driver), and there is no plan to
support it.

The "up" code (for example upboard_up_pinctrl_data) is for most boards
of the UP family (UP 7000, UPXi12, UP Squared Pro 7000 ...) but not the
UP Board [1]. Indeed for now there is no pinctrl mapping for these boards.

The "up2" code is for the UP Squared board which uses a different FPGA.

As I explained I only added pinctrl mapping for the UP Squared board, as
it was the easiest one (no need to add groups/functions in Intel pinctrl
driver). But the plan is to add support for other boards (UP 7000,
IPXi12 ...) later.

Regarding the name of the pinctrl mapping for UP Squared board, it is
indeed a bit confusing, I will rename it.

[1]
https://www.aaeon.com/en/product/detail/up-board-computer-board-for-professional-makers

Best Regards,

Thomas