Re: [PATCH v3] riscv: KGDB: Do not inline arch_kgdb_breakpoint()
From: WangYuli
Date: Thu Apr 10 2025 - 10:30:42 EST
Hi Alex
On 2025/4/10 21:42, Alexandre Ghiti wrote:
Hi WangYuli,
You forgot to replace kgdb_breakinst into kgdb_compiled_break.
OK, I'll fix it.
Thanks,
You are fixing 2 things here, you need to split this patch into 2.
OK,
And as noted by Palmer, we actually don't need norvc here, so you can
remove it instead.
I have some questions regarding this.
If .option norvc is unnecessary, what is the significance of .option
push/.option pop?
Should they also be removed as well?
However, will this still function properly when the RISC-V C extension
is active?
Thanks,
--
WangYuli
Attachment:
OpenPGP_0xC5DA1F3046F40BEE.asc
Description: OpenPGP public key
Attachment:
OpenPGP_signature.asc
Description: OpenPGP digital signature