Re: [PATCH v3] riscv: KGDB: Do not inline arch_kgdb_breakpoint()

[Alexandre Ghiti]

Hi WangYuli,

On 10/04/2025 16:28, WangYuli wrote:
> Hi Alex
>
> On 2025/4/10 21:42, Alexandre Ghiti wrote:
> > Hi WangYuli,
> >
> >
> > You forgot to replace kgdb_breakinst into kgdb_compiled_break.
>
> OK, I'll fix it.
>
> Thanks,
>
> > You are fixing 2 things here, you need to split this patch into 2. 
> OK,
> > And as noted by Palmer, we actually don't need norvc here, so you can 
> > remove it instead.
>
> I have some questions regarding this.
>
> If .option norvc is unnecessary, what is the significance of .option 
> push/.option pop?
>
> Should they also be removed as well?


Yes, you can remove them.


> However, will this still function properly when the RISC-V C extension 
> is active?


.option norvc is used to prevent the assembler from using compressed 
instructions, but it's generally used when we need to ensure the size of 
the instructions that are used, which is not the case here as noted by 
Palmer since we only care about the address. So yes it will work fine 
with C enabled :)


> Thanks,

Thanks for the changes!

Alex