Re: [PATCH] i2c: xgene-slimpro: Simplify PCC shared memory region handling
From: Sudeep Holla
Date: Mon Apr 14 2025 - 04:58:37 EST
On Mon, Apr 14, 2025 at 12:30:38AM +0200, Andi Shyti wrote:
> Hi Sudeep,
>
> On Fri, Apr 11, 2025 at 12:23:03PM +0100, Sudeep Holla wrote:
> > The PCC driver now handles mapping and unmapping of shared memory
> > areas as part of pcc_mbox_{request,free}_channel(). Without these before,
> > this xgene-slimpro I2C driver did handling of those mappings like several
> > other PCC mailbox client drivers.
> >
> > There were redundant operations, leading to unnecessary code. Maintaining
> > the consistency across these driver was harder due to scattered handling
> > of shmem.
> >
> > Just use the mapped shmem and remove all redundant operations from this
> > driver.
> >
> > Cc: Andi Shyti <andi.shyti@xxxxxxxxxx>
> > Cc: linux-i2c@xxxxxxxxxxxxxxx
> > Signed-off-by: Sudeep Holla <sudeep.holla@xxxxxxx>
>
> I thought this patch was going to take other paths. Anyway, I
> merged it to i2c/i2c-host.
>
Thanks, I too had assumed so, but the mailbox maintainer applied only PCC
mailbox changes only without any response in the thread. Sorry for that.
--
Regards,
Sudeep