Re: [PATCH] release_task: kill the no longer needed get/put_pid(thread_pid)
From: Oleg Nesterov
Date: Mon Apr 14 2025 - 16:46:29 EST
On 04/14, Mateusz Guzik wrote:
>
> > The task_pid() needs to be moved after the repeat label. I'm appending
> > the full patch I applied.
>
> oh heh, ack on that
Thanks...
> but while here perhaps a small stylistic cleanup: move
> add_device_randomness before or after proc_flush_pid + free_pids,
> instead of if being in-between
Agreed, I thought about this too from the very beginning.
I'd prefer to move add_device_randomness() after release_thread(),
but perhaps this needs another minor cleanup?
Oleg.