Re: [PATCH] release_task: kill the no longer needed get/put_pid(thread_pid)

[Mateusz Guzik]

On Mon, Apr 14, 2025 at 10:46 PM Oleg Nesterov <oleg@xxxxxxxxxx> wrote:
> I'd prefer to move add_device_randomness() after release_thread(),
> but perhaps this needs another minor cleanup?
>

I have no opinion on that front. As far as cosmetics go I would not
touch it past the nit I mentioned in my previous e-mail, but I'm not
going to protest any other changes.

imo the real thing to do concerning the routine is to figure out if
the call is even of any benefit -- it very well may be this is call is
only there because nobody with random-fu bothered to remove it.
Personally I have epsilon knowledge of that area, so I'm not even
going to try to evaluate it. But it would be nice if someone(tm)
reached out to random folk concerning it. Worst case, even if it still
has to be there, maybe the sucker can trylock and bail. It does
contribute to contention, likely for no good reason.

-- 
Mateusz Guzik <mjguzik gmail.com>