Re: [PATCH v5 08/11] drm/vc4: hdmi: switch to generic CEC helpers

From: Dmitry Baryshkov
Date: Tue Apr 15 2025 - 05:05:02 EST


On 14/04/2025 17:41, Maxime Ripard wrote:
On Mon, Apr 07, 2025 at 06:11:05PM +0300, Dmitry Baryshkov wrote:
+static const struct drm_connector_hdmi_cec_adapter_ops vc4_hdmi_cec_adap_ops = {
+ .base.unregister = drm_connector_hdmi_cec_unregister,
+ .init = vc4_hdmi_cec_init,
+ .enable = vc4_hdmi_cec_adap_enable,
+ .log_addr = vc4_hdmi_cec_adap_log_addr,
+ .transmit = vc4_hdmi_cec_adap_transmit,
+};

Did you compile it? it looks like drm_connector_hdmi_cec_adapter_ops has been renamed, and it
doesn't have a base.unregister field anymore?

It seems, I've changed my build tree config and this got disabled. I'll make sure that it is enabled for the next iteration.


Maxime


--
With best wishes
Dmitry