Re: [PATCH v3 01/54] vmlinux.lds.h: fixup HEADERED_SECTION{,_BY} macros

[Louis Chauvet]

Hi Jim,

Thanks a lot for this v3!

Le 02/04/2025 à 19:41, Jim Cromie a écrit :
> commit 1d926e259d8f ("vmlinux.lds.h: add HEADERED_SECTION_* macros")
>
> I flubbed the defn of the outer 2 macros; they missed the extra arg
> needed: _front/_hdr.  Fix it now, before anyone notices.

I don't see any usage of this change in the series. Is it related to it? 
If no, can you make this a separate series, it is already difficult to 
review the dyndbg part without unrelated noise?

> Signed-off-by: Jim Cromie <jim.cromie@xxxxxxxxx>

Reviewed-by: Louis Chauvet <louis.chauvet@xxxxxxxxxxx>

> ---
>   include/asm-generic/vmlinux.lds.h | 7 ++++---
>   1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
> index 0d5b186abee8..c9c66089ea2f 100644
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -219,10 +219,11 @@ defined(CONFIG_AUTOFDO_CLANG) || defined(CONFIG_PROPELLER_CLANG)
>   	KEEP(*(.gnu.linkonce.##_sec_))					\
>   	BOUNDED_SECTION_POST_LABEL(_sec_, _label_, _BEGIN_, _END_)
>   
> -#define HEADERED_SECTION_BY(_sec_, _label_)				\
> -	HEADERED_SECTION_PRE_LABEL(_sec_, _label_, __start, __stop)
> +#define HEADERED_SECTION_BY(_sec_, _label_, _front)			\
> +	HEADERED_SECTION_PRE_LABEL(_sec_, _label_, __start, __stop, _front)
>   
> -#define HEADERED_SECTION(_sec)	 HEADERED_SECTION_BY(_sec, _sec)
> +#define HEADERED_SECTION(_sec, _front) \
> +	HEADERED_SECTION_BY(_sec, _sec, _front)
>   
>   #ifdef CONFIG_TRACE_BRANCH_PROFILING
>   #define LIKELY_PROFILE()						\

--
Louis Chauvet, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com