Re: [PATCH v2] pinctrl: amd: Fix use of undeclared identifier 'pinctrl_amd_s2idle_dev_ops'

From: Rafael J. Wysocki
Date: Tue Apr 15 2025 - 09:37:38 EST


On Tue, Apr 15, 2025 at 3:34 PM Linus Walleij <linus.walleij@xxxxxxxxxx> wrote:
>
> On Mon, Apr 14, 2025 at 10:35 PM Mario Limonciello <superm1@xxxxxxxxxx> wrote:
>
> > From: Mario Limonciello <mario.limonciello@xxxxxxx>
> >
> > `pinctrl_amd_s2idle_dev_ops` is hidden under both `CONFIG_ACPI` and
> > `CONFIG_PM_SLEEP` so the functions that use it need the same scope.
> >
> > Adjust checks to look for both, and while updating make it CONFIG_SUSPEND
> > instead as that's what the acpi header uses.
> >
> > Reported-by: kernel test robot <lkp@xxxxxxxxx>
> > Closes: https://lore.kernel.org/oe-kbuild-all/202504100420.88UPkUTU-lkp@xxxxxxxxx/
> > Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxx>
> > ---
> > v2:
> > Use CONFIG_SUSPEND instead of CONFIG_PM_SLEEP
>
> This seems to be based on the previous fixes merged by Rafael?
>
> Do I need to rebase on -rc2 or something to merge this patch?
>
> Or can Rafael queue this too?

I can.

> In that case:
> Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>

Thanks!