Re: [net-next v10 4/7] net: mtip: The L2 switch driver for imx287

From: Simon Horman
Date: Fri May 02 2025 - 13:05:21 EST


On Fri, May 02, 2025 at 09:44:44AM +0200, Lukasz Majewski wrote:

> +static int mtip_sw_probe(struct platform_device *pdev)

...

> + ret = devm_request_irq(&pdev->dev, fep->irq, mtip_interrupt, 0,
> + dev_name(&pdev->dev), fep);
> + if (ret)
> + return dev_err_probe(&pdev->dev, fep->irq,

It looks like the 2nd argument to dev_err_probe() should be ret rather than
fep->irq.

Flagged by Smatch.

> + "Could not alloc IRQ\n");

...