Re: [net-next v10 4/7] net: mtip: The L2 switch driver for imx287

[Lukasz Majewski]

On Fri, 2 May 2025 18:05:03 +0100
Simon Horman <horms@xxxxxxxxxx> wrote:

> On Fri, May 02, 2025 at 09:44:44AM +0200, Lukasz Majewski wrote:
> 
> > +static int mtip_sw_probe(struct platform_device *pdev)  
> 
> ...
> 
> > +	ret = devm_request_irq(&pdev->dev, fep->irq,
> > mtip_interrupt, 0,
> > +			       dev_name(&pdev->dev), fep);
> > +	if (ret)
> > +		return dev_err_probe(&pdev->dev, fep->irq,  
> 
> It looks like the 2nd argument to dev_err_probe() should be ret
> rather than fep->irq.
> 

+1

> Flagged by Smatch.
> 
> > +				     "Could not alloc IRQ\n");  
> 
> ...




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@xxxxxxx

Attachment: pgpte8KogpYRP.pgp
Description: OpenPGP digital signature