Re: [PATCH v7 2/2] memory: mtk-smi: mt8188: Add SMI reset and clamp for MT8188

[Krzysztof Kozlowski]

On 30/04/2025 11:45, Friday Yang wrote:
> From: "Friday Yang" <friday.yang@xxxxxxxxxxxx>
> 
> To prevent handling glitch signals during MTCMOS on/off transitions,
> SMI requires clamp and reset operations. Parse the reset settings for
> SMI LARBs and the clamp settings for the SMI Sub-Common. Register
> genpd callback for the SMI LARBs located in image, camera and IPE
> subsystems, and apply reset and clamp operations within the callback.
> 
> Signed-off-by: Friday Yang <friday.yang@xxxxxxxxxxxx>
> Tested-by: Friday Yang <friday.yang@xxxxxxxxxxxx>

How is this possible? Are you claiming that none of other authors test
their patches? How testing would be not implied by authorship?

> Reviewed-by: Yong Wu <yong.wu@xxxxxxxxxxxx>
> Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@xxxxxxxxxxxxx>
> Acked-by: Rob Herring <robh@xxxxxxxxxx>

Changelog says that v7 has only following changes:

  - Remove the 'devm_pm_runtime_enable' change.

While v6 had no such tags.

No clue what happened here, but looks like mess with the tags and really
incomplete changelog.

Best regards,
Krzysztof