Re: [PATCH v7 1/2] dt-bindings: memory: mediatek: Add SMI reset and clamp for MT8188

From: Krzysztof Kozlowski
Date: Sun May 04 2025 - 09:42:36 EST


On 30/04/2025 11:45, Friday Yang wrote:
> From: "Friday Yang" <friday.yang@xxxxxxxxxxxx>
>
> Add 'resets' and 'reset-names' properties for SMI LARBs to support
> SMI reset operations.
> On the MediaTek platform, some SMI LARBs are directly connected to
> the SMI Common, while others are connected to the SMI Sub-Common,
> which in turn is connected to the SMI Common. The hardware block
> diagram can be described as follows.
>
> SMI-Common(Smart Multimedia Interface Common)
> |
> +----------------+------------------+
> | | |
> | | |
> | | |
> | | |
> | | |
> larb0 SMI-Sub-Common0 SMI-Sub-Common1
> | | | | |
> larb1 larb2 larb3 larb7 larb9
>
> Signed-off-by: Friday Yang <friday.yang@xxxxxxxxxxxx>
> Tested-by: Friday Yang <friday.yang@xxxxxxxxxxxx>

That's not possible. Otherwise explain me how do you test bindings (and
using static checkers is not testing).


> Reviewed-by: Yong Wu <yong.wu@xxxxxxxxxxxx>

Where? Provide lore link. That's a v7 so I expect all your work to be
done public.


Best regards,
Krzysztof